blimp/client/core/BUILD.gn - Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/BUILD.gn

Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public (Closed)

Patch Set: Fix findbugs issue Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/BUILD.gn

diff --git a/blimp/client/core/BUILD.gn b/blimp/client/core/BUILD.gn

index bf61664e99cfd933f7b57104d9971d90d047aefb..32c4566ecb3c558f336681da94ea16461bc1e441 100644

--- a/blimp/client/core/BUILD.gn

+++ b/blimp/client/core/BUILD.gn

@@ -30,7 +30,7 @@ group("core_shim") {

group("core") {

visibility = [

":core_shim",

- "//blimp/client/app:*", # TODO(nyquist): Remove this. See crbug/651964.

+ "//blimp/client/app:*", # TODO(nyquist): Remove when enable_blimp_client is gone.

"//blimp/client/test",

"//blimp/test/*",

]

@@ -97,7 +97,7 @@ if (is_android) {

visibility = [

":core_shim_java",

"//blimp/client:blimp_unittests_java_deps",

- "//blimp/client/app:*", # TODO(nyquist): Remove this. See crbug/651964.

+ "//blimp/client/app:*", # TODO(nyquist): Remove when enable_blimp_client is gone.

]

deps = [

« no previous file with comments | « blimp/client/app/session/test_client_session.cc ('k') | blimp/client/core/common/BUILD.gn » ('j') | no next file with comments »