blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java - Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java

Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public (Closed)

Patch Set: Self-review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/app/android/java/src/org/chromium/blimp/app/toolbar/Toolbar.java ('K') | « blimp/client/core/settings/BUILD.gn ('k') | blimp/client/core/switches/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java

diff --git a/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java b/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java

index 6b8611d9f2d66afb83b5d316445724d8a7237d91..855991b9ec7a103b928286947c4e306bef2f34b0 100644

--- a/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java

+++ b/blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java

@@ -53,15 +53,12 @@ public class AboutBlimpPreferences extends PreferenceFragment {

}

private static void addBlimpPreferences(PreferenceFragment fragment) {

- PreferenceScreen screen = fragment.getPreferenceScreen();

Preference blimpSetting = new Preference(fragment.getActivity());

blimpSetting.setTitle(R.string.blimp_about_blimp_preferences);

blimpSetting.setFragment(AboutBlimpPreferences.class.getName());

blimpSetting.setKey(PreferencesUtil.PREF_BLIMP_SWITCH);

- screen.addPreference(blimpSetting);

- fragment.setPreferenceScreen(screen);

+ fragment.getPreferenceScreen().addPreference(blimpSetting);

}

/**