blimp/client/core/geolocation/BUILD.gn - Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/geolocation/BUILD.gn

Issue 2542083004: Make //blimp/client/app a real embedder of //blimp/client/public (Closed)

Patch Set: Self-review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/geolocation/BUILD.gn

diff --git a/blimp/client/core/geolocation/BUILD.gn b/blimp/client/core/geolocation/BUILD.gn

index e0f44b188a674cae1a8e1f9ac1869598e6614fe8..b99945f11d089f44ad6d44bc378858ccd7378c16 100644

--- a/blimp/client/core/geolocation/BUILD.gn

+++ b/blimp/client/core/geolocation/BUILD.gn

@@ -9,7 +9,6 @@ if (is_android) {

source_set("geolocation") {

visibility = [

- "//blimp/client/app:session", # TODO(nyquist): Remove this. See crbug/651964.

"//blimp/client/core/*",

"//blimp/engine:browser_tests", # # TODO(nyquist): Remove this. See crbug/653789.

]