Sort headers for iteration

Sort headers for iteration

Fetch requires [1] that "the value pairs to iterate over are the
return value of running sort and combine with the header list", which
is to say we don't simply iterate over the internal data of Headers
but make a sorted (and combined) copy [2]. This manifested in some
failing imported cache tests that were sensitive to the order.

This CL implements making a copy and sorting the list for iteration;
it does not implement combining[3]. So not perfect but an incremental
improvement.

[1] https://fetch.spec.whatwg.org/#headers-class
[2] https://fetch.spec.whatwg.org/#concept-header-list-sort-and-combine
[3] https://fetch.spec.whatwg.org/#concept-header-value-combined

BUG=667376, 670439
R=yhirano@chromium.org

Committed: https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262
Cr-Commit-Position: refs/heads/master@{#436147}

[jsbell, 2016-12-01 21:08:00]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[jsbell, 2016-12-01 21:08:27]

yhirano@ - please take a look?

[commit-bot: I haz the power, 2016-12-01 21:08:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 22:51:30]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jsbell, 2016-12-02 00:40:05]

Failures are due to the cache storage tests not running with WPTServe at the
moment. I'll add those to the other tests marked pass/fail by dpranke.

[jsbell, 2016-12-02 00:42:19]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 00:42:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-12-02 01:57:08]

lgtm

https://codereview.chromium.org/2542073005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
(right):

https://codereview.chromium.org/2542073005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js:225: var
headers = new Headers;
[optional] I prefer |const| / |let| to |var|.

[commit-bot: I haz the power, 2016-12-02 02:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 02:07:28]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-12-02 17:03:42]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-12-02 17:03:43]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2542073005/#ps40001
(title: "no var")

[jsbell, 2016-12-02 17:03:50]

https://codereview.chromium.org/2542073005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
(right):

https://codereview.chromium.org/2542073005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js:225: var
headers = new Headers;
On 2016/12/02 01:57:07, yhirano wrote:
> [optional] I prefer |const| / |let| to |var|.

Done.

[commit-bot: I haz the power, 2016-12-02 17:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 22:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:16:40]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1835
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
ab95d5982f1d3f07684edf405b368b42b8c7b548..b2719a3ce3ae379f404c58704ae6171f305076c8
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1760,10 +1760,6 @@ crbug.com/666993
imported/wpt/html/webappapis/idle-callbacks/callback-idle-perio
 crbug.com/666993
imported/wpt/html/webappapis/idle-callbacks/callback-timeout-with-raf.html [
Timeout ]
 crbug.com/666993 imported/wpt/html/webappapis/idle-callbacks/basic.html [
Timeout ]
 
-# These tests (erroneously?) see a platform-specific 'server' header
-crbug.com/667376
imported/wpt/service-workers/cache-storage/window/cache-match.https.html [ Pass
Failure ]
-crbug.com/667376
imported/wpt/service-workers/cache-storage/window/cache-put.https.html [ Pass
Failure ]
-
 # Flaky on Linux dbg
 crbug.com/667953 [ Linux Debug ]
virtual/android/media/mediadocument/media-document-with-download-button.html [
Pass Failure ]
 
@@ -1835,6 +1831,8 @@ Bug(dpranke)
imported/wpt/service-workers/cache-storage/serviceworker/cache-stor
 Bug(dpranke)
imported/wpt/service-workers/cache-storage/serviceworker/cache-storage-match.https.html
[ Failure ]
 Bug(dpranke)
imported/wpt/service-workers/cache-storage/serviceworker/credentials.html [
Failure ]
 Bug(dpranke)
imported/wpt/service-workers/cache-storage/window/cache-add.https.html [ Failure
]
+Bug(dpranke)
imported/wpt/service-workers/cache-storage/window/cache-match.https.html [
Failure ]
+Bug(dpranke)
imported/wpt/service-workers/cache-storage/window/cache-put.https.html [ Failure
]
 Bug(dpranke)
imported/wpt/service-workers/cache-storage/worker/cache-add.https.html [ Failure
]
 Bug(dpranke)
imported/wpt/service-workers/cache-storage/worker/cache-match.https.html [
Failure ]
 Bug(dpranke)
imported/wpt/service-workers/cache-storage/worker/cache-put.https.html [ Failure
]

[jsbell, 2016-12-02 22:37:59]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-12-02 22:37:59]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2542073005/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-02 22:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 02:33:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480718279019320,
"parent_rev": "f64b62eb89534dc76cf9e684daf4c35cc16b9fe6", "commit_rev":
"07fe1f11271bc24189ba84c983363178f79c8ab5"}

[commit-bot: I haz the power, 2016-12-03 02:33:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-03 02:35:22]

Description was changed from

==========
Sort headers for iteration

Fetch requires [1] that "the value pairs to iterate over are the
return value of running sort and combine with the header list", which
is to say we don't simply iterate over the internal data of Headers
but make a sorted (and combined) copy [2]. This manifested in some
failing imported cache tests that were sensitive to the order.

This CL implements making a copy and sorting the list for iteration;
it does not implement combining[3]. So not perfect but an incremental
improvement.

[1] https://fetch.spec.whatwg.org/#headers-class
[2] https://fetch.spec.whatwg.org/#concept-header-list-sort-and-combine
[3] https://fetch.spec.whatwg.org/#concept-header-value-combined

BUG=667376,670439
R=yhirano@chromium.org
==========

to

==========
Sort headers for iteration

Fetch requires [1] that "the value pairs to iterate over are the
return value of running sort and combine with the header list", which
is to say we don't simply iterate over the internal data of Headers
but make a sorted (and combined) copy [2]. This manifested in some
failing imported cache tests that were sensitive to the order.

This CL implements making a copy and sorting the list for iteration;
it does not implement combining[3]. So not perfect but an incremental
improvement.

[1] https://fetch.spec.whatwg.org/#headers-class
[2] https://fetch.spec.whatwg.org/#concept-header-list-sort-and-combine
[3] https://fetch.spec.whatwg.org/#concept-header-value-combined

BUG=667376,670439
R=yhirano@chromium.org

Committed: https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262
Cr-Commit-Position: refs/heads/master@{#436147}
==========

[commit-bot: I haz the power, 2016-12-03 02:35:23]

Patchset 4 (id:??) landed as
https://crrev.com/abbafbc0bacfca5beada1e3d1a5299569e0a5262
Cr-Commit-Position: refs/heads/master@{#436147}