Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2542023003: Rename PageLoad.AbortTiming to PageLoad.Experimental.AbortTiming. (Closed)

Created:
4 years ago by Bryan McQuade
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PageLoad.AbortTiming to PageLoad.Experimental.AbortTiming. PageLoad.AbortTiming metrics have 'This metric is still experimental and not yet ready to be relied upon.' in their description, but don't use the more recent PageLoad metrics convention of being named starting with PageLoad.Experimental. This change fixes that. The existing PageLoad.AbortTiming metrics have a number of issues, as described in https://docs.google.com/document/d/1pH3LYp_Obt0gbM9qCLd6woH7TvaAV6Sma5xw--wXcQ0/edit. We'll be making changes to these metrics as we try to improve them. To make it clearer that these metrics aren't yet stable and shouldn't be depended on, this change renames all PageLoad.AbortTiming.* metrics to PageLoad.Experimental.AbortTiming.*. Once the experimental metrics stabilize, we'll establish new trusted metrics in the PageLoad.AbortTiming namespace. BUG=670358 Committed: https://crrev.com/2fd2976e2f214a191d46d3714d3a688efdc8fc31 Cr-Commit-Position: refs/heads/master@{#435818}

Patch Set 1 #

Patch Set 2 : fix histograms.xml #

Patch Set 3 : fix fromgooglesearch metrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -58 lines) Patch
M chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc View 1 chunk +28 lines, -25 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 1 2 1 chunk +38 lines, -32 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 12 chunks +145 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Bryan McQuade
PTAL, thanks!
4 years ago (2016-12-01 16:15:54 UTC) #6
Charlie Harrison
LGTM
4 years ago (2016-12-01 17:49:48 UTC) #10
Charlie Harrison
Could you add a BUG=?
4 years ago (2016-12-01 17:50:49 UTC) #11
Bryan McQuade
isherman, PTAL for histograms.xml change, thanks!
4 years ago (2016-12-01 18:05:08 UTC) #14
Ilya Sherman
histograms.xml lgtm
4 years ago (2016-12-02 01:44:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542023003/40001
4 years ago (2016-12-02 01:45:01 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-02 01:51:09 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-02 01:53:50 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2fd2976e2f214a191d46d3714d3a688efdc8fc31
Cr-Commit-Position: refs/heads/master@{#435818}

Powered by Google App Engine
This is Rietveld 408576698