runtime/observatory/tests/service/service_test_common.dart - Issue 2542003002: Add getIsolateID to Service class in dart:developer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/service_test_common.dart

Issue 2542003002: Add getIsolateID to Service class in dart:developer (Closed)

Patch Set: fix test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/service_test_common.dart

diff --git a/runtime/observatory/tests/service/service_test_common.dart b/runtime/observatory/tests/service/service_test_common.dart

index 2a68a528c6b3be88ffd91c24c2f284ea7fa2a59e..bf1d013c5d89c9c8d0e54ebac8802431b161ef11 100644

--- a/runtime/observatory/tests/service/service_test_common.dart

+++ b/runtime/observatory/tests/service/service_test_common.dart

@@ -157,7 +157,7 @@ Future<Isolate> hasPausedFor(Isolate isolate, String kind) {

isolate.vm.getEventStream(VM.kDebugStream).then((stream) {

var subscription;

subscription = stream.listen((ServiceEvent event) {

- if (event.kind == kind) {

+ if ((isolate == event.isolate) && (event.kind == kind)) {

if (completer != null) {

// Reload to update isolate.pauseEvent.

print('Paused with $kind');