Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2541933002: update analyzer cli to support include directive in analysis options file (Closed)

Created:
4 years ago by danrubel
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update analyzer cli to support include directive in analysis options file R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/aff6b796f3d12ba5c0f0d3796bc26b0aa50651d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments and merge #

Patch Set 3 : merge #

Messages

Total messages: 6 (2 generated)
danrubel
Incremental progress on https://github.com/dart-lang/sdk/issues/27817
4 years ago (2016-11-30 18:50:46 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2541933002/diff/1/pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart File pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart (right): https://codereview.chromium.org/2541933002/diff/1/pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart#newcode1 pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart:1: // Copyright (c) 2015, the Dart project authors. ...
4 years ago (2016-11-30 19:54:17 UTC) #3
danrubel
Committed patchset #3 (id:40001) manually as aff6b796f3d12ba5c0f0d3796bc26b0aa50651d5 (presubmit successful).
4 years ago (2016-11-30 20:17:06 UTC) #5
danrubel
4 years ago (2016-11-30 20:18:09 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2541933002/diff/1/pkg/analyzer_cli/test/data/...
File
pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart
(right):

https://codereview.chromium.org/2541933002/diff/1/pkg/analyzer_cli/test/data/...
pkg/analyzer_cli/test/data/options_include_directive_tests_project/lib/test_file.dart:1:
// Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
On 2016/11/30 19:54:17, Brian Wilkerson wrote:
> "2015" --> "2016"?

Good eyes. Fixed.

Powered by Google App Engine
This is Rietveld 408576698