MD Settings: Add Google Play Store (Arc++) section

chrome/browser/resources/settings/settings_main/settings_main.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{about: boolean, basic: boolean, advanced: boolean}}
  */
 var MainPageVisibility;
 
 /**
@@ skipping 75 matching lines @@
       type: Object,
       value: function() { return {}; },
     },
   },
 
   /** @override */
   attached: function() {
     this.listen(this, 'freeze-scroll', 'onFreezeScroll_');
     var currentRoute = settings.getCurrentRoute();
     this.hasExpandedSection_ = currentRoute && currentRoute.isSubpage();
+    if (!loadTimeData.getBoolean('androidAppsAllowed'))
+        this.pageVisibility.androidApps = false;

[michaelpg, 2016/12/01 20:15:34]

does this work? i'm worried about a couple things:

* it's not using this.set, so settings-ui and settings-menu are not notified of
the change (e.g., it won't hide it from the menu)
* it's happening dynamically, so i'm not convinced the page doesn't get stamped
first before hiding
* should we hide this in guest mode via settings_ui.js

[stevenjb, 2016/12/02 00:39:19]

Ugh. The way we handle pageVisibility is confusing. We use it one way for tests,
a different way for gues tmode.

Rather than make a major change to that code, I will just add a separate
property in settings_ui instead. (This was the wrong place for this regardless,
I didn't realize settings_ui was at the top of the tree).

[michaelpg, 2016/12/02 03:47:43]

Yeah... I don't know if there's a non-sucky way of doing this without fixing
pageVisibility.

   },
 
   /** @override */
   detached: function() {
     this.unlisten(this, 'freeze-scroll', 'onFreezeScroll_');
   },
 
   /** @private */
   overscrollChanged_: function() {
     if (!this.overscroll_ && this.boundScroll_) {
@@ skipping 250 matching lines @@
 
   /**
    * @param {(boolean|undefined)} visibility
    * @return {boolean} True unless visibility is false.
    * @private
    */
   showAdvancedSettings_: function(visibility) {
     return visibility !== false;
   },
 });