Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: chrome/browser/themes/theme_properties.cc

Issue 2541873004: Change default frame colors. Change custom titlebar colors on Windows. (Closed)
Patch Set: final osx behavior Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | chrome/browser/themes/theme_service_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_properties.cc
diff --git a/chrome/browser/themes/theme_properties.cc b/chrome/browser/themes/theme_properties.cc
index b63da408bb452e0a067bce171621a9a27ba41c80..3d09033caeca19b76c4bdac6b3be178ee69dd30d 100644
--- a/chrome/browser/themes/theme_properties.cc
+++ b/chrome/browser/themes/theme_properties.cc
@@ -24,22 +24,14 @@ namespace {
// browser_theme_pack.cc.
const SkColor kDefaultColorFrame = SkColorSetRGB(0xCC, 0xCC, 0xCC);
-#if defined(OS_MACOSX)
-// Used for theme fallback colors.
-const SkColor kDefaultColorFrameInactive = SkColorSetRGB(0xF6, 0xF6, 0xF6);
-#else
-const SkColor kDefaultColorFrameInactive = SkColorSetRGB(0xDC, 0xDC, 0xDC);
-#endif
#if defined(OS_MACOSX)
const SkColor kDefaultColorFrameIncognito =
SkColorSetARGB(0xE6, 0x14, 0x16, 0x18);
-const SkColor kDefaultColorFrameIncognitoInactive =
+const SkColor kDefaultColorFrameIncognitoInactiveMac =
SkColorSetRGB(0x1E, 0x1E, 0x1E);
#else
const SkColor kDefaultColorFrameIncognito = SkColorSetRGB(0x28, 0x2B, 0x2D);
-const SkColor kDefaultColorFrameIncognitoInactive =
- SkColorSetRGB(0x38, 0x3B, 0x3D);
#endif
const SkColor kDefaultColorToolbar = SkColorSetRGB(0xF2, 0xF2, 0xF2);
@@ -83,9 +75,9 @@ constexpr SkColor kDefaultColorButtonBackground = SK_ColorTRANSPARENT;
constexpr color_utils::HSL kDefaultTintButtons = {-1, -1, -1};
constexpr color_utils::HSL kDefaultTintButtonsIncognito = {-1, -1, 0.85};
constexpr color_utils::HSL kDefaultTintFrame = {-1, -1, -1};
-constexpr color_utils::HSL kDefaultTintFrameInactive = {-1, -1, 0.75};
+constexpr color_utils::HSL kDefaultTintFrameInactive = {-1, -1, 0.9};
constexpr color_utils::HSL kDefaultTintFrameIncognito = {-1, 0.2, 0.35};
-constexpr color_utils::HSL kDefaultTintFrameIncognitoInactive = {-1, 0.3, 0.6};
+constexpr color_utils::HSL kDefaultTintFrameIncognitoInactive = {-1, 0.2, 0.87};
constexpr color_utils::HSL kDefaultTintBackgroundTab = {-1, -1, 0.75};
// ----------------------------------------------------------------------------
@@ -236,8 +228,13 @@ SkColor ThemeProperties::GetDefaultColor(int id, bool otr) {
case COLOR_FRAME:
return otr ? kDefaultColorFrameIncognito : kDefaultColorFrame;
case COLOR_FRAME_INACTIVE:
- return otr ? kDefaultColorFrameIncognitoInactive
- : kDefaultColorFrameInactive;
+#if defined(OS_MACOSX)
+ if (otr)
+ return kDefaultColorFrameIncognitoInactiveMac;
+#endif
+ return color_utils::HSLShift(
+ GetDefaultColor(ThemeProperties::COLOR_FRAME, otr),
+ GetDefaultTint(ThemeProperties::TINT_FRAME_INACTIVE, false));
case COLOR_TOOLBAR:
return otr ? kDefaultColorToolbarIncognito : kDefaultColorToolbar;
case COLOR_TAB_TEXT:
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | chrome/browser/themes/theme_service_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698