Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2541853002: CSSSelectorWatch: avoid unnecessary hash table lookups. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
rune
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSSSelectorWatch: avoid unnecessary hash table lookups. Committed: https://crrev.com/de7abf1dc71a50841e99f1860d11268cd5d51a44 Cr-Commit-Position: refs/heads/master@{#435361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look. just something noticed while looking over hash table usage.
4 years ago (2016-11-30 15:53:57 UTC) #4
rune
lgtm, but remove empty R and BUG before landing.
4 years ago (2016-11-30 18:12:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541853002/1
4 years ago (2016-11-30 18:52:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 18:56:51 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 19:00:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de7abf1dc71a50841e99f1860d11268cd5d51a44
Cr-Commit-Position: refs/heads/master@{#435361}

Powered by Google App Engine
This is Rietveld 408576698