Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: src/builtins/builtins-string.cc

Issue 2541843006: [stubs] Add LoadFixedArrayElements with int index (Closed)
Patch Set: Remove unused variable Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins-string.cc
diff --git a/src/builtins/builtins-string.cc b/src/builtins/builtins-string.cc
index 6aeab6b04f23c60c6560efe134bf2b1dabf13730..7c0f2a5dd290ce805397d026111c319dea0d68ce 100644
--- a/src/builtins/builtins-string.cc
+++ b/src/builtins/builtins-string.cc
@@ -1282,9 +1282,7 @@ void Builtins::Generate_StringPrototypeIterator(
Node* native_context = assembler.LoadNativeContext(context);
Node* map = assembler.LoadFixedArrayElement(
Igor Sheludko 2016/12/01 12:26:57 This is actually LoadContextElement
jgruber 2016/12/01 14:10:33 Done.
- native_context,
- assembler.IntPtrConstant(Context::STRING_ITERATOR_MAP_INDEX), 0,
- CodeStubAssembler::INTPTR_PARAMETERS);
+ native_context, Context::STRING_ITERATOR_MAP_INDEX);
Node* iterator = assembler.Allocate(JSStringIterator::kSize);
assembler.StoreMapNoWriteBarrier(iterator, map);
assembler.StoreObjectFieldRoot(iterator, JSValue::kPropertiesOffset,
@@ -1441,9 +1439,7 @@ void Builtins::Generate_StringIteratorPrototypeNext(
{
Node* native_context = assembler.LoadNativeContext(context);
Node* map = assembler.LoadFixedArrayElement(
Igor Sheludko 2016/12/01 12:26:57 Same here.
jgruber 2016/12/01 14:10:32 Done.
- native_context,
- assembler.IntPtrConstant(Context::ITERATOR_RESULT_MAP_INDEX), 0,
- CodeStubAssembler::INTPTR_PARAMETERS);
+ native_context, Context::ITERATOR_RESULT_MAP_INDEX);
Node* result = assembler.Allocate(JSIteratorResult::kSize);
assembler.StoreMapNoWriteBarrier(result, map);
assembler.StoreObjectFieldRoot(result, JSIteratorResult::kPropertiesOffset,

Powered by Google App Engine
This is Rietveld 408576698