[stubs] Add LoadFixedArrayElements with int index

[stubs] Add LoadFixedArrayElements with int index

The overload simply wraps creation of an IntPtrConstant and makes things more
readable.

Committed: https://crrev.com/a72380f87b44a024f440869649077d89ca4e4bc7
Cr-Commit-Position: refs/heads/master@{#41430}

[jgruber, 2016-12-01 11:47:27]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 11:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 11:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 11:52:19]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jgruber, 2016-12-01 11:53:53]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 11:53:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-12-01 12:15:25]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org, mstarzinger@chromium.org

[jgruber, 2016-12-01 12:15:25]

mstarzinger for interpreter/
ishell for the rest

PTAL

[commit-bot: I haz the power, 2016-12-01 12:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 12:18:04]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-12-01 12:26:57]

Thanks! lgtm with nits:

https://codereview.chromium.org/2541843006/diff/20001/src/builtins/builtins-s...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2541843006/diff/20001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:1284: Node* map =
assembler.LoadFixedArrayElement(
This is actually LoadContextElement

https://codereview.chromium.org/2541843006/diff/20001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:1441: Node* map =
assembler.LoadFixedArrayElement(
Same here.

https://codereview.chromium.org/2541843006/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2541843006/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:1318: return LoadFixedArrayElement(native_context,
Context::ArrayMapIndex(kind));
LoadContextElement

[Michael Starzinger, 2016-12-01 12:59:59]

LGTM on "interpreter", didn't look at the rest at all.

[jgruber, 2016-12-01 13:36:13]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 14:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 14:02:35]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-12-01 14:10:33]

https://codereview.chromium.org/2541843006/diff/20001/src/builtins/builtins-s...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2541843006/diff/20001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:1284: Node* map =
assembler.LoadFixedArrayElement(
On 2016/12/01 12:26:57, Igor Sheludko wrote:
> This is actually LoadContextElement

Done.

https://codereview.chromium.org/2541843006/diff/20001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:1441: Node* map =
assembler.LoadFixedArrayElement(
On 2016/12/01 12:26:57, Igor Sheludko wrote:
> Same here.

Done.

[jgruber, 2016-12-01 14:11:05]

https://codereview.chromium.org/2541843006/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2541843006/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:1318: return LoadFixedArrayElement(native_context,
Context::ArrayMapIndex(kind));
On 2016/12/01 12:26:57, Igor Sheludko wrote:
> LoadContextElement

Done.

[jgruber, 2016-12-01 14:11:13]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-12-01 14:11:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2541843006/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-12-01 14:11:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 14:13:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480601473523110,
"parent_rev": "78e6852f61c8337123d82a1b71b5daae178e56db", "commit_rev":
"19be4ece8eea19573d78496b7ddc34d88211bc7c"}

[commit-bot: I haz the power, 2016-12-01 14:13:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-01 14:13:37]

Description was changed from

==========
[stubs] Add LoadFixedArrayElements with int index

The overload simply wraps creation of an IntPtrConstant and makes things more
readable.
==========

to

==========
[stubs] Add LoadFixedArrayElements with int index

The overload simply wraps creation of an IntPtrConstant and makes things more
readable.

Committed: https://crrev.com/a72380f87b44a024f440869649077d89ca4e4bc7
Cr-Commit-Position: refs/heads/master@{#41430}
==========

[commit-bot: I haz the power, 2016-12-01 14:13:38]

Patchset 3 (id:??) landed as
https://crrev.com/a72380f87b44a024f440869649077d89ca4e4bc7
Cr-Commit-Position: refs/heads/master@{#41430}