Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: pdf/pdf_engine.h

Issue 2541843005: Revert "Printing: Load the source PDF only once." (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/pdf.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index 4c7ce6335d671aa1e82c7976da7dd7c437ad256f..4bb62b3117d9e8fca2fc78ad6a2189e7dfc24c11 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -333,8 +333,9 @@ class PDFEngineExports {
static PDFEngineExports* Get();
#if defined(OS_WIN)
- // See the definitions of the corresponding functions in pdf.h for details.
- virtual bool RenderPDFPageToDC(void* pdf_handle,
+ // See the definition of RenderPDFPageToDC in pdf.cc for details.
+ virtual bool RenderPDFPageToDC(const void* pdf_buffer,
+ int buffer_size,
int page_number,
const RenderingSettings& settings,
HDC dc) = 0;
@@ -345,7 +346,9 @@ class PDFEngineExports {
virtual void SetPDFUseGDIPrinting(bool enable) = 0;
#endif // defined(OS_WIN)
- virtual bool RenderPDFPageToBitmap(void* pdf_handle,
+ // See the definition of RenderPDFPageToBitmap in pdf.cc for details.
+ virtual bool RenderPDFPageToBitmap(const void* pdf_buffer,
+ int pdf_buffer_size,
int page_number,
const RenderingSettings& settings,
void* bitmap_buffer) = 0;
@@ -353,12 +356,11 @@ class PDFEngineExports {
virtual bool GetPDFDocInfo(const void* pdf_buffer,
int buffer_size,
int* page_count,
- double* max_page_width,
- void** pdf_handle) = 0;
+ double* max_page_width) = 0;
- virtual void ReleasePDFHandle(void* pdf_handle) = 0;
-
- virtual bool GetPDFPageSizeByIndex(void* pdf_handle,
+ // See the definition of GetPDFPageSizeByIndex in pdf.cc for details.
+ virtual bool GetPDFPageSizeByIndex(const void* pdf_buffer,
+ int pdf_buffer_size,
int page_number,
double* width,
double* height) = 0;
« no previous file with comments | « pdf/pdf.cc ('k') | pdf/pdfium/pdfium_engine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698