Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2541843005: Revert "Printing: Load the source PDF only once." (Closed)

Created:
4 years ago by Tom Sepez
Modified:
3 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Printing: Load the source PDF only once." This reverts commit fe899c8e19e6be990d0254f040f14c4a6d4cee70. BUG=669797 TBR=thestig@chromium.org Committed: https://crrev.com/abff09f770ce966c365e9a1ffea6029e8b6ca3f8 Cr-Commit-Position: refs/heads/master@{#435646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -125 lines) Patch
M chrome/browser/printing/pdf_to_emf_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/chrome_utility_printing_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/printing_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/utility/printing_handler.cc View 10 chunks +15 lines, -27 lines 0 comments Download
M pdf/pdf.h View 4 chunks +17 lines, -16 lines 0 comments Download
M pdf/pdf.cc View 4 chunks +18 lines, -26 lines 0 comments Download
M pdf/pdf_engine.h View 3 chunks +10 lines, -8 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 2 chunks +7 lines, -6 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 4 chunks +31 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tom Sepez
4 years ago (2016-12-01 01:23:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541843005/1
4 years ago (2016-12-01 17:52:13 UTC) #7
Tom Sepez
TBR, reversion.
4 years ago (2016-12-01 17:52:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 17:56:44 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abff09f770ce966c365e9a1ffea6029e8b6ca3f8 Cr-Commit-Position: refs/heads/master@{#435646}
4 years ago (2016-12-01 17:58:56 UTC) #12
Lei Zhang
3 years, 10 months ago (2017-02-24 08:47:27 UTC) #13
Message was sent while issue was closed.
lgtm

I need to revisit this some day...

Powered by Google App Engine
This is Rietveld 408576698