Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: runtime/vm/object_test.cc

Issue 25418002: Respond to Ivan's code review comments from previous TBR cl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: PTAL Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 4cfee0b913c5f870798c09ff1462fb58a313e599..cba6d447f027c74ffb5fa31aaf5d0455237a0440 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -1544,11 +1544,8 @@ TEST_CASE(EscapeSpecialCharactersOneByteString) {
String::Handle(String::EscapeSpecialCharacters(str));
EXPECT(escaped_str.Equals("a\\n\\f\\b\\t\\v\\r\\\\\\$z"));
- const String& empty_str = String::Handle(
- OneByteString::New(static_cast<intptr_t>(0), Heap::kNew));
const String& escaped_empty_str =
- String::Handle(String::EscapeSpecialCharacters(empty_str));
- EXPECT_EQ(empty_str.Length(), 0);
+ String::Handle(String::EscapeSpecialCharacters(Symbols::Empty()));
EXPECT_EQ(escaped_empty_str.Length(), 0);
}
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698