Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2541793006: Clean up error message in schema-based policy validation (Closed)

Created:
4 years ago by emaxx
Modified:
4 years ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up error message in schema-based policy validation Make the error message a little bit more readable. Old example: "Dropping policy Undeclared for aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa because it's not valid: The schema is invalid. at " Example after the change: "Dropping policy Undeclared of component aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa due to error at root: The schema is invalid." BUG=none TEST=none Committed: https://crrev.com/4372393deb7e34ba940a3687910df7f7ff128e53 Cr-Commit-Position: refs/heads/master@{#435921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/policy/core/common/schema_map.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
emaxx
Julian, May I ask you to review this small cleanup CL? It's pretty low-priority.
4 years ago (2016-12-02 00:14:16 UTC) #7
pastarmovj
lgtm
4 years ago (2016-12-02 08:01:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541793006/1
4 years ago (2016-12-02 12:19:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 12:24:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 12:26:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4372393deb7e34ba940a3687910df7f7ff128e53
Cr-Commit-Position: refs/heads/master@{#435921}

Powered by Google App Engine
This is Rietveld 408576698