Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2541793004: [counters] Use the correct timers for background parsing (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] Use the correct timers for background parsing BUG= Committed: https://crrev.com/62d19db514f6be2c0b74130ade35e65b3d4f802d Cr-Commit-Position: refs/heads/master@{#41436}

Patch Set 1 #

Patch Set 2 : remove old code #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M src/parsing/parser.cc View 1 1 chunk +14 lines, -6 lines 1 comment Download
M src/parsing/preparser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-01 15:47:09 UTC) #4
vogelheim
lgtm https://codereview.chromium.org/2541793004/diff/20001/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2541793004/diff/20001/src/parsing/parser.cc#newcode2744 src/parsing/parser.cc:2744: } For my understanding: What about the 'else' ...
4 years ago (2016-12-01 15:57:42 UTC) #5
Camillo Bruni
On 2016/12/01 at 15:57:42, vogelheim wrote: > lgtm > > https://codereview.chromium.org/2541793004/diff/20001/src/parsing/parser.cc > File src/parsing/parser.cc (right): ...
4 years ago (2016-12-01 16:43:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541793004/20001
4 years ago (2016-12-01 16:43:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 17:09:10 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 17:09:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62d19db514f6be2c0b74130ade35e65b3d4f802d
Cr-Commit-Position: refs/heads/master@{#41436}

Powered by Google App Engine
This is Rietveld 408576698