Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2541793003: scheduler: Fix engine_test.go after luci/gae roll. (Closed)

Created:
4 years ago by Vadim Sh.
Modified:
4 years ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

scheduler: Fix engine_test.go after luci/gae roll. Looks like luci/gae now uses RNG differently, screwing up test expectations for engine (that also uses same context-bound RNG). R=iannucci@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/02db70b96779838560dab93fc464776afd847b00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M scheduler/appengine/engine/engine_test.go View 9 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Vadim Sh.
PTAL Well, I can introduce a mock for RNG in the Engine code itself to ...
4 years ago (2016-11-30 22:01:46 UTC) #1
iannucci1
heh lgtm
4 years ago (2016-11-30 22:46:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541793003/1
4 years ago (2016-11-30 22:46:29 UTC) #5
iannucci
(lgtm from my non-alter-ego too)
4 years ago (2016-11-30 22:47:15 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-30 22:53:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/02db70b96779838560dab93fc464776afd847b00

Powered by Google App Engine
This is Rietveld 408576698