[GN] Add support for generated proguard configs in android_apk

[GN] Add support for generated proguard configs in android_apk

BUG=669961
Committed: https://crrev.com/6130422db2a8ff2a08ab0cd2b19d861825c900ae
Cr-Commit-Position: refs/heads/master@{#435460}

[kapishnikov, 2016-11-30 17:47:11]

Description was changed from

==========
[GN] Add support for generated proguard configs in android_apk

BUG=
==========

to

==========
[GN] Add support for generated proguard configs in android_apk

BUG=669961
==========

[kapishnikov, 2016-11-30 17:53:10]

kapishnikov@chromium.org changed reviewers:
+ jbudorick@chromium.org

[kapishnikov, 2016-11-30 17:53:10]

Hi John, could you take a look at this small change? Please see the bug for more
info.

I also posted a question on
https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/yTm4xefKd28

[kapishnikov, 2016-11-30 18:01:26]

I should have added:

      if (defined(deps)) {
        deps += [ ... ]
      } else {
        deps = [ ... ]
      }

I will upload a fix.

[kapishnikov, 2016-11-30 18:02:19]

https://codereview.chromium.org/2541763003/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2541763003/diff/1/build/config/android/rules....
build/config/android/rules.gni:1840: deps += [
Will add:
      if (defined(deps)) {
        deps += [ ... ]
      } else {
        deps = [ ... ]
      }

[jbudorick, 2016-11-30 18:05:40]

https://codereview.chromium.org/2541763003/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2541763003/diff/1/build/config/android/rules....
build/config/android/rules.gni:1840: deps += [
On 2016/11/30 18:02:18, kapishnikov wrote:
> Will add:
>       if (defined(deps)) {
>         deps += [ ... ]
>       } else {
>         deps = [ ... ]
>       }

nit: do

  if (!defined(deps)) {
    deps = []
  }

  deps += [ ... ]

[kapishnikov, 2016-11-30 19:57:22]

On 2016/11/30 18:05:40, jbudorick wrote:
>
https://codereview.chromium.org/2541763003/diff/1/build/config/android/rules.gni
> File build/config/android/rules.gni (right):
> 
>
https://codereview.chromium.org/2541763003/diff/1/build/config/android/rules....
> build/config/android/rules.gni:1840: deps += [
> On 2016/11/30 18:02:18, kapishnikov wrote:
> > Will add:
> >       if (defined(deps)) {
> >         deps += [ ... ]
> >       } else {
> >         deps = [ ... ]
> >       }
> 
> nit: do
> 
>   if (!defined(deps)) {
>     deps = []
>   }
> 
>   deps += [ ... ]

This is much nicer. Done!

[jbudorick, 2016-11-30 20:36:42]

lgtm

[kapishnikov, 2016-11-30 20:54:35]

The CQ bit was checked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2016-11-30 20:55:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:55:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480539275648760,
"parent_rev": "5392e638580ad7e9849249098807b374da1d8a76", "commit_rev":
"ba16ca1bf754f6441e9a867533dd4cd2d4006691"}

[commit-bot: I haz the power, 2016-11-30 22:55:31]

Description was changed from

==========
[GN] Add support for generated proguard configs in android_apk

BUG=669961
==========

to

==========
[GN] Add support for generated proguard configs in android_apk

BUG=669961
==========

[commit-bot: I haz the power, 2016-11-30 22:55:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-30 22:58:34]

Description was changed from

==========
[GN] Add support for generated proguard configs in android_apk

BUG=669961
==========

to

==========
[GN] Add support for generated proguard configs in android_apk

BUG=669961

Committed: https://crrev.com/6130422db2a8ff2a08ab0cd2b19d861825c900ae
Cr-Commit-Position: refs/heads/master@{#435460}
==========

[commit-bot: I haz the power, 2016-11-30 22:58:35]

Patchset 4 (id:??) landed as
https://crrev.com/6130422db2a8ff2a08ab0cd2b19d861825c900ae
Cr-Commit-Position: refs/heads/master@{#435460}