Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2541763002: Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects() (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Invalidate previousLocationInBacking in LayoutObject::clearPreviousVisualRects() clearPreviousVisualRects() is called when the object's previous visual rects become invalid (e.g. when the object becomes composited). We should call setMayNeedPaintInvalidationSubtree to ensure paint invalidation checking of subtree which would be triggered by changed location if we had valid previous location. BUG=666267 TEST=paint/invalidation/compositing/become-composited-zero-offset.html Review-Url: https://codereview.chromium.org/2537653002 Cr-Commit-Position: refs/heads/master@{#434894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/become-composited-zero-offset.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/become-composited-zero-offset-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Xianzhu
4 years ago (2016-11-30 04:57:51 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
da6d8eeac5782b308510d970f61dc9f606dd5523.

Powered by Google App Engine
This is Rietveld 408576698