Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2541753002: Use precomputed constant for determining if static is lazy-init (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use precomputed constant for determining if static is lazy-init R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/dfd38a04635c9eb59b3ca0d60c1b60e7c2f72034

Patch Set 1 #

Patch Set 2 : fix type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 1 chunk +11 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
~30 tests that format lists now pass.
4 years ago (2016-11-30 04:48:05 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-11-30 17:16:08 UTC) #3
sra1
4 years ago (2016-11-30 21:32:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dfd38a04635c9eb59b3ca0d60c1b60e7c2f72034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698