Issue 254173002: Fixed comment in memory test expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254173002: Fixed comment in memory test expectations. (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)

Modified:
6 years, 7 months ago

Reviewers:
bajones

CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, Zhenyao Mo, alokp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed comment in memory test expectations. BUG=368037 TBR=bajones@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266985

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/test/gpu/gpu_tests/memory_expectations.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Committed patchset #1 manually as r266985 (presubmit successful).

6 years, 7 months ago (2014-04-29 22:53:32 UTC) #2

bajones

6 years, 7 months ago (2014-04-29 23:10:16 UTC) #3

Message was sent while issue was closed.

On 2014/04/29 22:53:32, Ken Russell wrote:
> Committed patchset #1 manually as r266985 (presubmit successful).

LGTM, though I wonder if we shouldn't just make that read "Test_Name" across the
board to prevent the need to update this for every new expectations file. That
said, it is nice to have a more concrete example there, especially for empty
files. Takes some of the format guesswork out.

Expand Messages | Collapse Messages