Source/core/loader/FormSubmission.cpp - Issue 25417007: Handle crash when submitting an injected form on an "image page".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FormSubmission.cpp

Issue 25417007: Handle crash when submitting an injected form on an "image page". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test cleanup and rebase code. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/images/image-page-injected-script-crash-expected.txt ('k') | Source/core/platform/network/FormDataBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/FormSubmission.cpp

diff --git a/Source/core/loader/FormSubmission.cpp b/Source/core/loader/FormSubmission.cpp

index 3a728d1b5728d452abbf989fe2c62f301f594ca4..56e8919bbcd83932a3218f075b839228ec55427c 100644

--- a/Source/core/loader/FormSubmission.cpp

+++ b/Source/core/loader/FormSubmission.cpp

@@ -203,7 +203,7 @@ PassRefPtr<FormSubmission> FormSubmission::create(HTMLFormElement* form, const A

isMultiPartForm = false;

}

- WTF::TextEncoding dataEncoding = isMailtoForm ? UTF8Encoding() : FormDataBuilder::encodingFromAcceptCharset(copiedAttributes.acceptCharset(), document.inputEncoding());

+ WTF::TextEncoding dataEncoding = isMailtoForm ? UTF8Encoding() : FormDataBuilder::encodingFromAcceptCharset(copiedAttributes.acceptCharset(), document.inputEncoding(), document.defaultCharset());

RefPtr<DOMFormData> domFormData = DOMFormData::create(dataEncoding.encodingForFormSubmission());

Vector<pair<String, String> > formValues;