Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: runtime/vm/flow_graph_optimizer.cc

Issue 25417003: Disable string interpolation optimization until fixed. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_optimizer.h" 5 #include "vm/flow_graph_optimizer.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/cha.h" 8 #include "vm/cha.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flow_graph_builder.h" 10 #include "vm/flow_graph_builder.h"
(...skipping 6017 matching lines...) Expand 10 before | Expand all | Expand 10 after
6028 } 6028 }
6029 6029
6030 6030
6031 void ConstantPropagator::VisitPolymorphicInstanceCall( 6031 void ConstantPropagator::VisitPolymorphicInstanceCall(
6032 PolymorphicInstanceCallInstr* instr) { 6032 PolymorphicInstanceCallInstr* instr) {
6033 SetValue(instr, non_constant_); 6033 SetValue(instr, non_constant_);
6034 } 6034 }
6035 6035
6036 6036
6037 void ConstantPropagator::VisitStaticCall(StaticCallInstr* instr) { 6037 void ConstantPropagator::VisitStaticCall(StaticCallInstr* instr) {
6038 SetValue(instr, non_constant_);
6039 return;
6040 // TODO(srdjan): Enable code below once issues resolved.
6038 if (IsNonConstant(instr->constant_value())) { 6041 if (IsNonConstant(instr->constant_value())) {
6039 // Do not bother with costly analysis if we already know that the 6042 // Do not bother with costly analysis if we already know that the
6040 // instruction is not a constant. 6043 // instruction is not a constant.
6041 SetValue(instr, non_constant_); 6044 SetValue(instr, non_constant_);
6042 return; 6045 return;
6043 } 6046 }
6044 MethodRecognizer::Kind recognized_kind = 6047 MethodRecognizer::Kind recognized_kind =
6045 MethodRecognizer::RecognizeKind(instr->function()); 6048 MethodRecognizer::RecognizeKind(instr->function());
6046 if (recognized_kind == MethodRecognizer::kStringBaseInterpolate) { 6049 if (recognized_kind == MethodRecognizer::kStringBaseInterpolate) {
6047 // static String _interpolate(List values) 6050 // static String _interpolate(List values)
(...skipping 1704 matching lines...) Expand 10 before | Expand all | Expand 10 after
7752 } 7755 }
7753 7756
7754 // Insert materializations at environment uses. 7757 // Insert materializations at environment uses.
7755 for (intptr_t i = 0; i < exits.length(); i++) { 7758 for (intptr_t i = 0; i < exits.length(); i++) {
7756 CreateMaterializationAt(exits[i], alloc, alloc->cls(), *fields); 7759 CreateMaterializationAt(exits[i], alloc, alloc->cls(), *fields);
7757 } 7760 }
7758 } 7761 }
7759 7762
7760 7763
7761 } // namespace dart 7764 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698