Add Information Tooltip for Public Suffix List Matches

chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java

Index: chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
index 4c41262fb1945784f7eb33a5ab13b333c6e4846c..6dbaa4171c2bb05a3e0d076c838436980eb2a01b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.password_manager;
 import android.app.Activity;
 import android.content.Context;
 import android.content.DialogInterface;
+import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.support.v7.app.AlertDialog;
 import android.text.SpannableString;
@@ -14,18 +15,23 @@ import android.text.Spanned;
 import android.text.TextUtils;
 import android.text.method.LinkMovementMethod;
 import android.text.style.ClickableSpan;
+import android.view.Gravity;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ArrayAdapter;
+import android.widget.ImageButton;
 import android.widget.ImageView;
 import android.widget.ListView;
 import android.widget.TextView;
 
+import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.signin.AccountManagementFragment;
+import org.chromium.components.url_formatter.UrlFormatter;
 import org.chromium.ui.base.WindowAndroid;
+import org.chromium.ui.widget.Toast;
 
 /**
  *  A dialog offers the user the ability to choose credentials for authentication. User is
@@ -138,6 +144,20 @@ public class AccountChooserDialog
                     secondaryNameView.setVisibility(View.VISIBLE);
                 }
 
+                ImageButton pslInfoButton =
+                        (ImageButton) convertView.findViewById(R.id.psl_info_btn);
+                final String originUrl = credential.getOriginUrl();
+
+                if (!originUrl.isEmpty()) {
+                    pslInfoButton.setVisibility(View.VISIBLE);
+                    pslInfoButton.setOnClickListener(new View.OnClickListener() {
+                        @Override
+                        public void onClick(View view) {
+                            prepareButtonView((ImageButton) view, originUrl);
+                        }
+                    });
+                }
+
                 return convertView;
             }
         };
@@ -181,6 +201,42 @@ public class AccountChooserDialog
         mDialog.show();
     }
 
+    private void prepareButtonView(ImageButton buttonView, String originUrl) {

[gone, 2016/12/13 23:14:30]

This isn't really preparing a the buttonView; it's showing a tooltip.  Can you
make this more generic so it can be used elsewhere?

1) Call it showTooltip()
2) Take in a View instead of an ImageButton
3) Pass in a "message" instead of "originUrl", calling
formatUrlForSecurityDisplay where this function is called from instead.
4) Pass in the layout ID to inflate
5) Maybe move it to UiUtils#showTooltip()

[jdoerrie, 2016/12/14 16:04:01]

How do you suggest we pass gravity, xOffset, yOffset and duration to the toast?
These will be probably different for each call site. I would like to avoid a
lengthy signature like
showTooltip(View view, String message, int layoutId, int gravity, int xOffset,
int yOffset, int duration), but I don't know how we can avoid this. Maybe we
should just return a Toast and the call site is responsible for showing it and
setting gravity and duration?

[gone, 2016/12/14 18:20:42]

Eh, passing the Toast back would defeat most of the abstraction I was aiming
for.  How about you keep the file in this place for now and I'll yank it out and
adjust it later?  Just generalize the function prototype as much as you think
makes sense for now.

[jdoerrie, 2016/12/15 13:27:18]

Done.

+        Context context = buttonView.getContext();
+        Resources resources = context.getResources();
+
+        LayoutInflater inflater = LayoutInflater.from(context);
+        View layout = inflater.inflate(R.layout.psl_info_tooltip,
+                (ViewGroup) buttonView.findViewById(R.id.psl_info_tooltip));

[gone, 2016/12/13 23:14:30]

1) I'd avoid having a layout with the same name as the ID; gets confusing to
read it later.

2) Pretty sure it's just returning null when you do a search on buttonView for
that ID, anyway.  You're telling the LayoutInflater to inflate the tooltip
LinearLayout as a child of itself before it's been inflated.

3) You actually want to pass in null, anyway -- the tooltip is set as the View
of the Toast below.

[jdoerrie, 2016/12/15 13:27:18]

Done.

+
+        TextView text = (TextView) layout.findViewById(R.id.psl_info_tooltip_text);
+        text.setText(UrlFormatter.formatUrlForSecurityDisplay(originUrl, true /* showScheme */));
+        text.announceForAccessibility(text.getText());
+
+        final int screenWidth = resources.getDisplayMetrics().widthPixels;
+        final int screenHeight = resources.getDisplayMetrics().heightPixels;
+
+        final int[] screenPos = new int[2];
+        buttonView.getLocationOnScreen(screenPos);
+
+        final int width = buttonView.getWidth();
+        final int tooltipMargin = resources.getDimensionPixelSize(R.dimen.psl_info_tooltip_margin);
+
+        // The toast should be shown above and to the left (right for RTL) of the info button.
+        // In order to avoid measuring the size of the toast offsets are specified with regard
+        // to the bottom right / left corner of the screen.
+        final int xOffset = ApiCompatibilityUtils.isLayoutRtl(buttonView)
+                ? screenPos[0]
+                : screenWidth - screenPos[0] - width;
+        final int yOffset = screenHeight - screenPos[1] + tooltipMargin;
+
+        Toast toast = new Toast(context);
+        toast.setGravity(Gravity.BOTTOM | Gravity.END, xOffset, yOffset);
+        toast.setDuration(Toast.LENGTH_SHORT);
+        toast.setView(layout);
+        toast.show();
+    }
+
     @CalledByNative
     private void imageFetchComplete(int index, Bitmap avatarBitmap) {
         if (mIsDestroyed) return;