Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4380)

Unified Diff: chrome/android/java/res/layout/account_chooser_dialog_item.xml

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)
Patch Set: UI Overhaul Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/account_chooser_dialog_item.xml
diff --git a/chrome/android/java/res/layout/account_chooser_dialog_item.xml b/chrome/android/java/res/layout/account_chooser_dialog_item.xml
index 41875eca79a4c77c33d5a6b6f413688a9f7a003f..f49b5eee89f9b228a9db7da7f2ceff27c7587f99 100644
--- a/chrome/android/java/res/layout/account_chooser_dialog_item.xml
+++ b/chrome/android/java/res/layout/account_chooser_dialog_item.xml
@@ -3,7 +3,7 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<LinearLayout
+<RelativeLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
@@ -15,14 +15,16 @@
android:id="@+id/profile_image"
android:layout_width="40dp"
android:layout_height="40dp"
- android:layout_gravity="center_vertical"
+ android:layout_centerVertical="true"
android:contentDescription="@null"/>
<LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_gravity="center_vertical"
+ android:layout_centerVertical="true"
android:layout_margin="8dp"
android:layout_marginStart="16dp"
+ android:layout_toEndOf="@+id/profile_image"
+ android:layout_toStartOf="@+id/psl_info_icon"
android:orientation="vertical">
<TextView
android:id="@+id/main_name"
@@ -43,4 +45,12 @@
android:textColor="@color/descriptive_text_color"
android:textSize="@dimen/account_chooser_dialog_title_descriptive_text_size"/>
</LinearLayout>
-</LinearLayout>
+ <ImageView
+ android:id="@+id/psl_info_icon"
+ android:layout_width="@dimen/psl_info_icon_width"
Bernhard Bauer 2016/12/06 16:46:42 Keep the attributes sorted?
jdoerrie 2016/12/06 17:39:52 Done.
+ android:layout_height="@dimen/psl_info_icon_height"
+ android:padding="@dimen/psl_info_icon_padding"
+ android:layout_alignParentEnd="true"
+ android:layout_centerVertical="true"
+ android:contentDescription="@null"/>
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698