chrome/android/java/res/layout/account_chooser_dialog_item.xml - Issue 2541693004: Add Information Tooltip for Public Suffix List Matches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/account_chooser_dialog_item.xml

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)

Patch Set: Addressed Nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable/material_tooltip_background.xml ('k') | chrome/android/java/res/layout/material_tooltip.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/account_chooser_dialog_item.xml

diff --git a/chrome/android/java/res/layout/account_chooser_dialog_item.xml b/chrome/android/java/res/layout/account_chooser_dialog_item.xml

index 41875eca79a4c77c33d5a6b6f413688a9f7a003f..b5d24e2e9bce3f6aa5b69ee5804edd874b586e41 100644

--- a/chrome/android/java/res/layout/account_chooser_dialog_item.xml

+++ b/chrome/android/java/res/layout/account_chooser_dialog_item.xml

@@ -7,6 +7,7 @@

xmlns:android="http://schemas.android.com/apk/res/android"

android:layout_width="match_parent"

android:layout_height="wrap_content"

+ android:gravity="center_vertical"

android:minHeight="64dp"

android:paddingStart="@dimen/account_chooser_dialog_item_margin"

android:paddingEnd="@dimen/account_chooser_dialog_item_margin"

@@ -15,12 +16,10 @@

android:id="@+id/profile_image"

android:layout_width="40dp"

android:layout_height="40dp"

- android:layout_gravity="center_vertical"

android:contentDescription="@null"/>

<LinearLayout

android:layout_width="wrap_content"

android:layout_height="wrap_content"

- android:layout_gravity="center_vertical"

android:layout_margin="8dp"

android:layout_marginStart="16dp"

android:orientation="vertical">

@@ -43,4 +42,18 @@

android:textColor="@color/descriptive_text_color"

android:textSize="@dimen/account_chooser_dialog_title_descriptive_text_size"/>

</LinearLayout>

+

+ <Space

+ android:layout_width="0dp"

+ android:layout_height="0dp"

+ android:layout_weight="1" />

+ <ImageButton

+ android:id="@+id/psl_info_btn"

+ android:layout_height="wrap_content"

+ android:layout_width="wrap_content"

+ android:background="?attr/selectableItemBackground"

+ android:contentDescription="@null"

+ android:padding="4dp"

+ android:src="@drawable/btn_info"

+ android:visibility="gone"/>

</LinearLayout>