Add Information Tooltip for Public Suffix List Matches

chrome/android/java/res/values/dimens.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <resources>
     <!-- Connection info popup dimensions -->
     <dimen name="connection_info_padding_wide">24dp</dimen>
     <dimen name="connection_info_padding_thin">16dp</dimen>
 
@@ skipping 321 matching lines @@
     <dimen name="custom_tabs_screenshot_width">190dp</dimen>
 
     <!-- Favicon dimensions -->
     <dimen name="default_favicon_size">16dp</dimen>
     <dimen name="default_favicon_corner_radius">3dp</dimen>
     <dimen name="default_favicon_icon_text_size">10dp</dimen>
     <dimen name="default_favicon_min_size">16px</dimen>
 
     <!-- Account chooser dialog dimensions -->
     <dimen name="account_chooser_dialog_margin">24dp</dimen>
-    <dimen name="account_chooser_dialog_item_margin">20dp</dimen>
+    <dimen name="account_chooser_dialog_item_margin">24dp</dimen>
     <dimen name="account_chooser_dialog_title_main_text_size">18sp</dimen>
     <dimen name="account_chooser_dialog_title_descriptive_text_size">16sp</dimen>
 
+    <!-- Public Suffix List (PSL) info icon and tooltip dimensions -->
+    <dimen name="psl_info_btn_padding">4dp</dimen>
+    <dimen name="psl_info_tooltip_text_size">14sp</dimen>
+    <dimen name="psl_info_tooltip_horizontal_padding">16dp</dimen>
+    <dimen name="psl_info_tooltip_height">32dp</dimen>
+    <dimen name="psl_info_tooltip_margin">8dp</dimen>

[jdoerrie, 2016/12/13 17:24:48]

I would like to avoid specifying this into so much detail, but the designer
wants to see the official Material Design spec applied to the tooltip: 

https://material.google.com/components/tooltips.html#tooltips-tooltips-mobile

Is there a nicer way to achieve the same result?

[gone, 2016/12/13 23:14:30]

Annoyingly, no.  We generally get redlines with numbers and plug them in like
this.  I would suggest just plugging most of these numbers directly into the
layout XML, though -- they're used only that file and they're not different
between tablet and phone layouts.  I think margin is the only one that's used in
the code now.

+
     <!-- Clear browsing data preferences dimensions -->
     <dimen name="clear_browsing_data_checkbox_height">56dp</dimen>
 
     <!-- Payments UI
          * payments_section_checking_spacing:
            The spec says that the "Checking" text should be 32dp above the bottom of its section.
            We improvise by using 6dp because sections also have a 10dp padding, so we end up with
            a 16dp bottom margin on the "Checking" text + 10dp section padding + 6dp leftover.
     -->
     <dimen name="payments_section_vertical_spacing">10dp</dimen>
@@ skipping 29 matching lines @@
          https://www.google.com/design/spec/components/dialogs.html#dialogs-simple-dialogs -->
     <dimen name="dialog_width_unit">56dp</dimen>  <!-- MD dialog widths are multiples of this. -->
 
     <!-- Downloads dimensions. -->
     <dimen name="downloads_item_icon_size">48dp</dimen>
 
     <!--  Miscellaneous dimensions -->
     <dimen name="action_bar_shadow_height">10dp</dimen>
     <dimen name="selectable_list_layout_end_icon">24dp</dimen>
 </resources>