chrome/android/java/res/drawable/psl_info_icon_background.xml - Issue 2541693004: Add Information Tooltip for Public Suffix List Matches

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/psl_info_icon_background.xml

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)

Patch Set: Addressed comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2

	3 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	4

	5 Use of this source code is governed by a BSD-style license that can be

	6 found in the LICENSE file.

	7 -->

	8

	9 <shape xmlns:android="http://schemas.android.com/apk/res/android">
	gone 2016/12/08 01:32:44 Setting a background drawable overrides the platfo Setting a background drawable overrides the platform-wide Material rippling effect. I don't think you (or the designer) want that. jdoerrie 2016/12/13 17:24:48 Acknowledged. Show quoted text On 2016/12/08 01:32:44, dfalcantara (check my queue) wrote: > Setting a background drawable overrides the platform-wide Material rippling > effect. I don't think you (or the designer) want that. Acknowledged.
	10 <solid android:color="#14000000"/>

	11 <padding android:left="4dp"

	12 android:top="4dp"

	13 android:right="4dp"

	14 android:bottom="4dp"/>

	15 <corners android:radius="1dp"/>

	16 </shape>

OLD	NEW