Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2541683003: Clean ReadingListModel. (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
Reviewers:
gambard
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean ReadingListModel. These methods are not used anymore, remove them. BUG=664924 Committed: https://crrev.com/5f6b74a8224ffced64a047930911255431be9343 Cr-Commit-Position: refs/heads/master@{#435621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -133 lines) Patch
M components/reading_list/ios/reading_list_model.h View 1 chunk +0 lines, -11 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.h View 3 chunks +0 lines, -16 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.cc View 12 chunks +0 lines, -83 lines 0 comments Download
M components/reading_list/ios/reading_list_model_observer.h View 1 chunk +0 lines, -13 lines 0 comments Download
M components/reading_list/ios/reading_list_model_unittest.mm View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Olivier
4 years ago (2016-11-30 16:19:07 UTC) #2
gambard
lgtm
4 years ago (2016-12-01 08:22:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541683003/1
4 years ago (2016-12-01 16:02:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 16:12:27 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 16:14:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f6b74a8224ffced64a047930911255431be9343
Cr-Commit-Position: refs/heads/master@{#435621}

Powered by Google App Engine
This is Rietveld 408576698