Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2541633003: [wasm] Move wasm runtime functions to runtime-wasm.cc (Closed)

Created:
4 years ago by ahaas
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move wasm runtime functions to runtime-wasm.cc I removed {IsWasmInstance} because it is not used anywhere, and I moved ThrowWasmError to runtime-wasm.cc R=titzer@chromium.org Committed: https://crrev.com/4d75ea60823a0e4b4d564f2f6105de7ffb37e64e Cr-Commit-Position: refs/heads/master@{#41382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -65 lines) Patch
M src/runtime/runtime.h View 3 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +0 lines, -63 lines 0 comments Download
M src/runtime/runtime-wasm.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ahaas
4 years ago (2016-11-30 10:06:12 UTC) #1
titzer
On 2016/11/30 10:06:12, ahaas wrote: lgtm
4 years ago (2016-11-30 10:07:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541633003/1
4 years ago (2016-11-30 10:35:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 10:37:10 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 10:37:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d75ea60823a0e4b4d564f2f6105de7ffb37e64e
Cr-Commit-Position: refs/heads/master@{#41382}

Powered by Google App Engine
This is Rietveld 408576698