Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.h

Issue 2541633002: Convert GraphicsLayer from ASSERT to DCHECK (Closed)
Patch Set: Address review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 private: 298 private:
299 // Returns true if PaintController::paintArtifact() changed and needs commit. 299 // Returns true if PaintController::paintArtifact() changed and needs commit.
300 bool paintWithoutCommit( 300 bool paintWithoutCommit(
301 const IntRect* interestRect, 301 const IntRect* interestRect,
302 GraphicsContext::DisabledMode = GraphicsContext::NothingDisabled); 302 GraphicsContext::DisabledMode = GraphicsContext::NothingDisabled);
303 303
304 // Adds a child without calling updateChildList(), so that adding children 304 // Adds a child without calling updateChildList(), so that adding children
305 // can be batched before updating. 305 // can be batched before updating.
306 void addChildInternal(GraphicsLayer*); 306 void addChildInternal(GraphicsLayer*);
307 307
308 #if ENABLE(ASSERT) 308 #if DCHECK_IS_ON()
309 bool hasAncestor(GraphicsLayer*) const; 309 bool hasAncestor(GraphicsLayer*) const;
310 #endif 310 #endif
311 311
312 void incrementPaintCount() { ++m_paintCount; } 312 void incrementPaintCount() { ++m_paintCount; }
313 313
314 void notifyFirstPaintToClient(); 314 void notifyFirstPaintToClient();
315 315
316 // Helper functions used by settors to keep layer's the state consistent. 316 // Helper functions used by settors to keep layer's the state consistent.
317 void updateChildList(); 317 void updateChildList();
318 void updateLayerIsDrawable(); 318 void updateLayerIsDrawable();
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 }; 408 };
409 409
410 } // namespace blink 410 } // namespace blink
411 411
412 #ifndef NDEBUG 412 #ifndef NDEBUG
413 // Outside the blink namespace for ease of invocation from gdb. 413 // Outside the blink namespace for ease of invocation from gdb.
414 void PLATFORM_EXPORT showGraphicsLayerTree(const blink::GraphicsLayer*); 414 void PLATFORM_EXPORT showGraphicsLayerTree(const blink::GraphicsLayer*);
415 #endif 415 #endif
416 416
417 #endif // GraphicsLayer_h 417 #endif // GraphicsLayer_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698