Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2541613002: DO NOT SUBMIT: Sketching out ScriptLoader::executeScriptAsync.

Created:
4 years ago by jbroman
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT SUBMIT: Sketching out ScriptLoader::executeScriptAsync. BUG=591558

Patch Set 1 #

Patch Set 2 : more messing about #

Patch Set 3 : fwd decl #

Patch Set 4 : trim #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -28 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 2 3 4 5 3 chunks +46 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 2 3 4 5 6 7 8 8 chunks +123 lines, -27 lines 0 comments Download

Depends on Patchset:

Issue 2564903002 Patch 1

Messages

Total messages: 24 (24 generated)
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 18:47:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/1
4 years ago (2016-11-29 18:47:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-29 18:58:58 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/314682)
4 years ago (2016-11-29 18:58:58 UTC) #4
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 20:35:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/20001
4 years ago (2016-11-29 20:36:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-29 20:50:52 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/314802)
4 years ago (2016-11-29 20:50:52 UTC) #8
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 21:55:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/40001
4 years ago (2016-11-29 21:56:05 UTC) #10
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 22:05:53 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/60001
4 years ago (2016-11-29 22:06:22 UTC) #12
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 22:36:18 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/80001
4 years ago (2016-11-29 22:36:38 UTC) #14
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 22:37:55 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/100001
4 years ago (2016-11-29 22:38:03 UTC) #16
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-11-29 23:30:35 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/120001
4 years ago (2016-11-29 23:31:02 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-30 01:35:56 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ...
4 years ago (2016-11-30 01:35:56 UTC) #20
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
4 years ago (2016-12-06 16:11:55 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541613002/140001
4 years ago (2016-12-06 16:12:04 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-06 16:24:28 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-06 16:24:29 UTC) #24 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698