Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java

Issue 2541593002: [Cronet] Move setExperimentalOptions() to ExperimentalCronetEngine.Builder (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java b/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
index ba4efa7942aa3c51e69d3764b355f30c9e371864..6fc67f4e5dca45fe487bb39ffeebecf393797967 100644
--- a/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java
@@ -170,6 +170,17 @@ public abstract class ExperimentalCronetEngine extends CronetEngine {
return this;
}
+ /**
+ * Sets experimental options to be used in Cronet.
+ *
+ * @param options JSON formatted experimental options.
+ * @return the builder to facilitate chaining.
+ */
+ public Builder setExperimentalOptions(String options) {
+ mBuilderDelegate.setExperimentalOptions(options);
+ return this;
+ }
+
@VisibleForTesting
ICronetEngineBuilder getBuilderDelegate() {
return mBuilderDelegate;
@@ -240,12 +251,6 @@ public abstract class ExperimentalCronetEngine extends CronetEngine {
}
@Override
- public Builder setExperimentalOptions(String options) {
- super.setExperimentalOptions(options);
- return this;
- }
-
- @Override
public ExperimentalCronetEngine build() {
return mBuilderDelegate.build();
}
« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698