Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2541593002: [Cronet] Move setExperimentalOptions() to ExperimentalCronetEngine.Builder (Closed)

Created:
4 years ago by kapishnikov
Modified:
4 years ago
Reviewers:
pauljensen, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move setExperimentalOptions() to ExperimentalCronetEngine.Builder The setExperimentalOptions() method is considered to be an experimental. Its behavior may change in the future. For that reason, it is moved to ExperimentalCronetEngine.Builder instead of being in CronetEngine.Builder. BUG=629299 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/bbf208767c14dce67d643b02218bd842dd16cf9a Cr-Commit-Position: refs/heads/master@{#435669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +0 lines, -11 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kapishnikov
4 years ago (2016-11-29 18:23:09 UTC) #3
pauljensen
lgtm, in the commit description you might want to: 1. give some motivation, like "Experimental ...
4 years ago (2016-11-30 14:12:08 UTC) #4
mef
lgtm
4 years ago (2016-11-30 18:22:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541593002/1
4 years ago (2016-12-01 18:44:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 19:11:05 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 19:15:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbf208767c14dce67d643b02218bd842dd16cf9a
Cr-Commit-Position: refs/heads/master@{#435669}

Powered by Google App Engine
This is Rietveld 408576698