Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2541563002: [Interpreter] Remove skips for tests that no longer seem to be flaky. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove skips for tests that no longer seem to be flaky. BUG=v8:4680 Committed: https://crrev.com/8037e98e4483a75f863e350482f18a4e91045911 Cr-Commit-Position: refs/heads/master@{#41378}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -12 lines 1 comment Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -13 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rmcilroy
Michael, as far as I can tell these test no longer fail on Ignition. Are ...
4 years ago (2016-11-29 18:01:39 UTC) #6
Michael Achenbach
lgtm sure, lets watch the bots. https://codereview.chromium.org/2541563002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (left): https://codereview.chromium.org/2541563002/diff/1/test/cctest/cctest.status#oldcode332 test/cctest/cctest.status:332: # BUG(5193): Flaky. ...
4 years ago (2016-11-30 09:19:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541563002/1
4 years ago (2016-11-30 09:19:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 09:21:18 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 09:21:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8037e98e4483a75f863e350482f18a4e91045911
Cr-Commit-Position: refs/heads/master@{#41378}

Powered by Google App Engine
This is Rietveld 408576698