Kill vestigial transfer requests

Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
TBR=creis@chromium.org,lukasza@chromium.org
NOTRY=true
NOPRESUBMIT=true

[Charlie Harrison, 2016-11-29 15:18:15]

Description was changed from

==========
Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
==========

to

==========
Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
TBR=creis@chromium.org,lukasza@chromium.org
==========

[Charlie Harrison, 2016-11-29 15:18:46]

csharrison@chromium.org changed reviewers:
+ creis@chromium.org, lukasza@chromium.org

[Charlie Harrison, 2016-11-29 15:18:47]

Merging vestigial transfer requests to M56
TBR creis, lukasza

[Charlie Harrison, 2016-11-29 15:18:59]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:19:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 15:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:19:15]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[Charlie Harrison, 2016-11-29 15:19:57]

Description was changed from

==========
Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
TBR=creis@chromium.org,lukasza@chromium.org
==========

to

==========
Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
TBR=creis@chromium.org,lukasza@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

[Charlie Harrison, 2016-11-29 15:20:09]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:20:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 15:23:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480432809159610, "parent_rev":
"5f21406ecc5f8958d98e043dac84ba7f59bdad1b", "commit_rev":
"7628299693d2b4ee54801d3ac898cb5566e89c0b"}

[commit-bot: I haz the power, 2016-11-29 15:24:23]

Description was changed from

==========
Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
TBR=creis@chromium.org,lukasza@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Kill vestigial transfer requests

When requests are marked as transferring, we mark them as protected in
the ResourceDispatcherHostImpl, so when their RFH goes away we won't
lose the request.

However, there are cases where the transfer can fail, and the navigation
abandoned, while the request on the IO thread is still marked as
protected.

This patch catches that case by checking for transferring navigation
handles in ~RFH, and cancelling them there.

Browser test written by lukasza@chromium.org

BUG=657195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508973006
Cr-Commit-Position: refs/heads/master@{#433430}
(cherry picked from commit f2466b80b0cd892d31fdf69a397905eaacbfb3b5)
TBR=creis@chromium.org,lukasza@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-11-29 15:24:27]

Committed patchset #1 (id:1)