Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254153002: [webcrypto] Make operations run on a background thread so they don't block the blink thread. (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Make operations run on a background thread so they don't block the blink thread. More details on threading strategy provided in webcrypto_impl.cc. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267176

Patch Set 1 : cherry-pick of original #

Patch Set 2 : Fix bug from first landing #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1095 lines, -385 lines) Patch
M content/child/webcrypto/jwk.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/child/webcrypto/jwk.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M content/child/webcrypto/platform_crypto.h View 12 chunks +47 lines, -14 lines 0 comments Download
M content/child/webcrypto/platform_crypto_nss.cc View 49 chunks +163 lines, -78 lines 0 comments Download
M content/child/webcrypto/platform_crypto_openssl.cc View 17 chunks +41 lines, -33 lines 0 comments Download
M content/child/webcrypto/shared_crypto.h View 7 chunks +24 lines, -19 lines 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 26 chunks +69 lines, -53 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 3 chunks +128 lines, -5 lines 0 comments Download
M content/child/webcrypto/status.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/child/webcrypto/webcrypto_impl.h View 2 chunks +2 lines, -7 lines 0 comments Download
M content/child/webcrypto/webcrypto_impl.cc View 1 2 14 chunks +599 lines, -133 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 2 chunks +1 line, -10 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 1 chunk +4 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
This is a continuation of https://codereview.chromium.org/233733004/
6 years, 7 months ago (2014-04-29 22:38:08 UTC) #1
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-04-29 22:45:20 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-04-30 03:32:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/254153002/40001
6 years, 7 months ago (2014-04-30 03:34:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 05:22:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 05:22:26 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-04-30 05:39:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/254153002/40001
6 years, 7 months ago (2014-04-30 05:39:41 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 11:19:01 UTC) #9
Message was sent while issue was closed. 
Change committed as 267176

Powered by Google App Engine
This is Rietveld 408576698