third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2541513004: Ensure scrollToFragmentAnchor called before restoreScrollPositionAndViewState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2541513004: Ensure scrollToFragmentAnchor called before restoreScrollPositionAndViewState. (Closed)

Patch Set: revert navigation_controller_impl_browsertest.cc style Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index b42da5159917ed6d0fa5d353d69374a060836dc3..f3e15a1aa2f87a7328f92394449a59bef928c9d9 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -643,6 +643,10 @@ void FrameView::setContentsSize(const IntSize& size) {

updateParentScrollableAreaSet();

page->chromeClient().contentsSizeChanged(m_frame.get(), size);

+ // Ensure the scrollToFragmentAnchor is called before

+ // restoreScrollPositionAndViewState when reload

+ scrollToFragmentAnchor();

bokan 2016/12/02 17:10:41 I think you can remove it from performPostLayoutTa

frame().loader().restoreScrollPositionAndViewState();

}

« no previous file with comments | « content/test/data/navigation_controller/reload-with-url-anchor.html ('k') | no next file » | no next file with comments »