Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2541513003: Changes to language.status to fix broken tests on vm-reload and analyzer. (Closed)

Created:
4 years ago by bkonyi
Modified:
4 years ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Changes to language.status to fix broken tests on vm-reload and analyzer. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/d406779dd860a98d97d1546616d58885b19f71e9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated language.status to fix failing vm-kernel test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tests/language/language.status View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bkonyi
Hopefully this is it...
4 years ago (2016-11-29 23:58:34 UTC) #2
zra
+johnmccutchan for question about status https://codereview.chromium.org/2541513003/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/2541513003/diff/1/tests/language/language.status#newcode306 tests/language/language.status:306: vm/regress_27201_test: Pass, Crash # ...
4 years ago (2016-11-30 00:04:59 UTC) #4
Cutch
https://codereview.chromium.org/2541513003/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/2541513003/diff/1/tests/language/language.status#newcode306 tests/language/language.status:306: vm/regress_27201_test: Pass, Crash # Requires deferred libraries On 2016/11/30 ...
4 years ago (2016-11-30 00:05:43 UTC) #5
zra
lgtm but let's just land this now to make the buildbot green again.
4 years ago (2016-11-30 00:06:47 UTC) #6
bkonyi
4 years ago (2016-11-30 00:08:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d406779dd860a98d97d1546616d58885b19f71e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698