Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2541513002: Update documentation for num.clamp. (Closed)

Created:
4 years ago by floitsch
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update documentation for num.clamp. (partially) fixes #27923 BUG= http://dartbug.com/27923 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/222d80ad9d59762de3c4537afd8ff8d2a994bf75

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/lib/core/num.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
4 years ago (2016-11-29 14:29:34 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2541513002/diff/1/sdk/lib/core/num.dart File sdk/lib/core/num.dart (right): https://codereview.chromium.org/2541513002/diff/1/sdk/lib/core/num.dart#newcode300 sdk/lib/core/num.dart:300: * The arguments [lowerLimit] and [upperLimit] must be ...
4 years ago (2016-11-29 16:00:50 UTC) #3
floitsch
https://codereview.chromium.org/2541513002/diff/1/sdk/lib/core/num.dart File sdk/lib/core/num.dart (right): https://codereview.chromium.org/2541513002/diff/1/sdk/lib/core/num.dart#newcode300 sdk/lib/core/num.dart:300: * The arguments [lowerLimit] and [upperLimit] must be a ...
4 years ago (2016-12-01 19:00:49 UTC) #4
floitsch
4 years ago (2016-12-01 19:01:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
222d80ad9d59762de3c4537afd8ff8d2a994bf75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698