Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2541503002: [android] Make pdfium_unittests work on Android. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

[android] Make pdfium_unittests work on Android. This updates test.gni to match chromium as of crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923, changes how PathService::GetSourceDir behaves on Android, and specifies the runtime test data for test_support. BUG=pdfium:415 Committed: https://pdfium.googlesource.com/pdfium/+/f6ee820732b8717d32d85a47938172080067ce4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -127 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M testing/test.gni View 10 chunks +36 lines, -126 lines 0 comments Download
M testing/utils/path_service.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jbudorick
4 years ago (2016-11-29 14:17:33 UTC) #2
dsinclair
lgtm
4 years ago (2016-12-05 14:23:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541503002/1
4 years ago (2016-12-05 14:23:57 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-05 14:50:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f6ee820732b8717d32d85a47938172080067...

Powered by Google App Engine
This is Rietveld 408576698