TBR: fix build break

runtime/vm/object_test.cc

Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 9578fcc5dd093ab9b9ed601740778ea9ad673f1e..4cfee0b913c5f870798c09ff1462fb58a313e599 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -1544,7 +1544,8 @@ TEST_CASE(EscapeSpecialCharactersOneByteString) {
       String::Handle(String::EscapeSpecialCharacters(str));
   EXPECT(escaped_str.Equals("a\\n\\f\\b\\t\\v\\r\\\\\\$z"));
 
-  const String& empty_str = String::Handle(OneByteString::New(0, Heap::kNew));
+  const String& empty_str = String::Handle(
+      OneByteString::New(static_cast<intptr_t>(0), Heap::kNew));

[Ivan Posva, 2013/10/01 03:21:23]

You can remove the this whole line and replace the parameter of
EscapeSpecialCharacters with Symbols::Empty().

   const String& escaped_empty_str =
       String::Handle(String::EscapeSpecialCharacters(empty_str));
   EXPECT_EQ(empty_str.Length(), 0);

[Ivan Posva, 2013/10/01 03:21:23]

This is a redundant check. If Symbols::Empty() is not empty we have bigger
issues.

@@ -1591,7 +1592,8 @@ TEST_CASE(EscapeSpecialCharactersTwoByteString) {
       String::Handle(String::EscapeSpecialCharacters(str));
   EXPECT(escaped_str.Equals("a\\n\\f\\b\\t\\v\\r\\\\\\$z"));
 
-  const String& empty_str = String::Handle(TwoByteString::New(0, Heap::kNew));
+  const String& empty_str =
+      String::Handle(TwoByteString::New(static_cast<intptr_t>(0), Heap::kNew));
   const String& escaped_empty_str =
       String::Handle(String::EscapeSpecialCharacters(empty_str));
   EXPECT_EQ(empty_str.Length(), 0);