Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2541493004: Enable -Werror for links in asan builds. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable -Werror for links in asan builds. Rolls buildtools by one to pick up https://codereview.chromium.org/2531333002/ BUG=669072 Committed: https://crrev.com/e5144ca400abd436c2f332ac438a58e3d6e63460 Cr-Commit-Position: refs/heads/master@{#435286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Nico
First to stamp wins!
4 years ago (2016-11-30 15:16:59 UTC) #4
Reid Kleckner
lgtm
4 years ago (2016-11-30 16:25:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541493004/1
4 years ago (2016-11-30 16:26:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541493004/1
4 years ago (2016-11-30 16:30:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 16:31:26 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5144ca400abd436c2f332ac438a58e3d6e63460 Cr-Commit-Position: refs/heads/master@{#435286}
4 years ago (2016-11-30 16:34:09 UTC) #16
Dirk Pranke
4 years ago (2016-12-01 00:05:11 UTC) #17
Message was sent while issue was closed.
lgtm also.

Powered by Google App Engine
This is Rietveld 408576698