Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2541463002: [turbofan] Keep the next bytecode liveness when analysing (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Keep the next bytecode liveness when analysing Since the majority of bytecodes have a next instruction, and we iterate over the bytecodes backwards, we can keep the previous seen (i.e. sequentially next) bytecode's liveness on a variable instead of looking it up again. Committed: https://crrev.com/9b5962720ac5b05e2b751ddb46bb892bf323f7e9 Cr-Commit-Position: refs/heads/master@{#41361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M src/compiler/bytecode-analysis.cc View 9 chunks +25 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Leszek Swirski
Hi Jaro, Can you take a look at this? I think this is a no-brainer ...
4 years ago (2016-11-29 13:57:58 UTC) #6
Jarin
lgtm
4 years ago (2016-11-29 14:10:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541463002/1
4 years ago (2016-11-29 14:10:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 14:12:13 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 14:12:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b5962720ac5b05e2b751ddb46bb892bf323f7e9
Cr-Commit-Position: refs/heads/master@{#41361}

Powered by Google App Engine
This is Rietveld 408576698