Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2541443002: Revert of [ignition/turbo] Perform liveness analysis on the bytecodes (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
Reviewers:
Jarin, rmcilroy, Yang
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ignition/turbo] Perform liveness analysis on the bytecodes (patchset #17 id:320001 of https://codereview.chromium.org/2523893003/ ) Reason for revert: Breaks the build: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/14886 Original issue's description: > [ignition/turbo] Perform liveness analysis on the bytecodes > > Replaces the graph-based liveness analyzer in the bytecode graph builder > with an initial bytecode-based liveness analysis pass, which is added to > the existing loop extent analysis. > > Now the StateValues in the graph have their inputs initialised to > optimized_out, rather than being modified after the graph is built. > > Committed: https://crrev.com/1852300954c216c29cf93444430681d213e87925 > Cr-Commit-Position: refs/heads/master@{#41344} TBR=jarin@chromium.org,rmcilroy@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a2e2a39ff1096d82cc944dacb849116e3c773ee1 Cr-Commit-Position: refs/heads/master@{#41346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -1106 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/bytecode-analysis.h View 3 chunks +2 lines, -28 lines 0 comments Download
M src/compiler/bytecode-analysis.cc View 3 chunks +9 lines, -399 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 23 chunks +119 lines, -83 lines 0 comments Download
D src/compiler/bytecode-liveness-map.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/compiler/bytecode-liveness-map.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M src/interpreter/bytecode-array-accessor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-accessor.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +16 lines, -19 lines 0 comments Download
M src/interpreter/bytecode-label.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/interpreter/control-flow-builders.h View 8 chunks +8 lines, -11 lines 0 comments Download
M src/interpreter/control-flow-builders.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -4 lines 0 comments Download
M test/debugger/debug/debug-evaluate-with.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/debug-liveedit-restart-frame.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/es6/default-parameters-debug.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/regress-5207.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-131994.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-5071.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-222893.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/debug-evaluate-bool-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate-with-context.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-scopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-blockscopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-debug-scopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/modules-debug-scopes1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D test/unittests/compiler/bytecode-analysis-unittest.cc View 1 chunk +0 lines, -415 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Leszek Swirski
Created Revert of [ignition/turbo] Perform liveness analysis on the bytecodes
4 years ago (2016-11-29 10:51:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541443002/1
4 years ago (2016-11-29 10:51:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 10:51:32 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-29 10:52:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2e2a39ff1096d82cc944dacb849116e3c773ee1
Cr-Commit-Position: refs/heads/master@{#41346}

Powered by Google App Engine
This is Rietveld 408576698