[Offline pages] Switching ChangeRequestsStateTask to use RequestQueueStore::GetRequestsByIds

components/offline_pages/background/change_requests_state_task_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/background/change_requests_state_task.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/test/test_simple_task_runner.h"
@@ skipping 127 matching lines @@
   AddItemsToStore(&store);
 
   std::vector<int64_t> request_ids{kRequestId1, kRequestId2};
   ChangeRequestsStateTask task(
       &store, request_ids, SavePageRequest::RequestState::PAUSED,
       base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
                  base::Unretained(this)));
   task.Run();
   PumpLoop();
   ASSERT_TRUE(last_result());
-  EXPECT_EQ(2UL, last_result()->item_statuses.size());
-  EXPECT_EQ(kRequestId1, last_result()->item_statuses.at(0).first);
+  ASSERT_EQ(2UL, last_result()->item_statuses.size());
+
+  int index_id_1 =

[Pete Williamson, 2016/12/02 01:39:06]

Why are you doing this?  I found the code easier to understand before, is it now
wrong because the algorithm returns things slightly differently?

[fgorski, 2016/12/02 22:32:03]

Yes, we did make some changes, mainly the fact that the dictionary might be
returning values in a different order on different platforms... hence this
change.

+      last_result()->item_statuses.at(0).first == kRequestId1 ? 0 : 1;
+  int index_id_2 = 1 - index_id_1;
+
+  EXPECT_EQ(kRequestId1, last_result()->item_statuses.at(index_id_1).first);
   EXPECT_EQ(ItemActionStatus::SUCCESS,
-            last_result()->item_statuses.at(0).second);
-  EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(1).first);
+            last_result()->item_statuses.at(index_id_1).second);
+  EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(index_id_2).first);
   EXPECT_EQ(ItemActionStatus::SUCCESS,
-            last_result()->item_statuses.at(1).second);
-  EXPECT_EQ(2UL, last_result()->updated_items.size());
-  EXPECT_EQ(kRequestId1, last_result()->updated_items.at(0).request_id());
+            last_result()->item_statuses.at(index_id_2).second);
+  ASSERT_EQ(2UL, last_result()->updated_items.size());
+  EXPECT_EQ(kRequestId1,
+            last_result()->updated_items.at(index_id_1).request_id());
   EXPECT_EQ(SavePageRequest::RequestState::PAUSED,
-            last_result()->updated_items.at(0).request_state());
-  EXPECT_EQ(kRequestId2, last_result()->updated_items.at(1).request_id());
+            last_result()->updated_items.at(index_id_1).request_state());
+  EXPECT_EQ(kRequestId2,
+            last_result()->updated_items.at(index_id_2).request_id());
   EXPECT_EQ(SavePageRequest::RequestState::PAUSED,
-            last_result()->updated_items.at(1).request_state());
+            last_result()->updated_items.at(index_id_2).request_state());
 }
 
 TEST_F(ChangeRequestsStateTaskTest, EmptyRequestsList) {
   RequestQueueInMemoryStore store;
   InitializeStore(&store);
 
   std::vector<int64_t> request_ids;
   ChangeRequestsStateTask task(
       &store, request_ids, SavePageRequest::RequestState::PAUSED,
       base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
@@ skipping 11 matching lines @@
   AddItemsToStore(&store);
 
   std::vector<int64_t> request_ids{kRequestId1, kRequestId3};
   ChangeRequestsStateTask task(
       &store, request_ids, SavePageRequest::RequestState::PAUSED,
       base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
                  base::Unretained(this)));
   task.Run();
   PumpLoop();
   ASSERT_TRUE(last_result());
-  EXPECT_EQ(2UL, last_result()->item_statuses.size());
+  ASSERT_EQ(2UL, last_result()->item_statuses.size());

[Pete Williamson, 2016/12/02 01:39:06]

Why the change from EXPECT to ASSERT?

[fgorski, 2016/12/02 22:32:03]

When we have too many, I don't have to look at the error message too long to
work out what the problem is.,

when we have too little, there will be a crash later (when accessing the first
missing index), and I prefer to crash early.

   EXPECT_EQ(kRequestId1, last_result()->item_statuses.at(0).first);
   EXPECT_EQ(ItemActionStatus::SUCCESS,
             last_result()->item_statuses.at(0).second);
   EXPECT_EQ(kRequestId3, last_result()->item_statuses.at(1).first);
   EXPECT_EQ(ItemActionStatus::NOT_FOUND,
             last_result()->item_statuses.at(1).second);
   EXPECT_EQ(1UL, last_result()->updated_items.size());
   EXPECT_EQ(SavePageRequest::RequestState::PAUSED,
             last_result()->updated_items.at(0).request_state());
 }
 
 }  // namespace offline_pages