Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2541403002: cc mojo: Serialize/deserialize missed field in TextureDrawQuads (Closed)

Created:
4 years ago by Fady Samuel
Modified:
4 years ago
Reviewers:
Tom Sepez, vmpstr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc mojo: Serialize/deserialize missed field in TextureDrawQuads resource_size_in_pixels was missed in TextureDrawQuad. This was missed because unit tests used SetNew instead of SetAll and only set all set the resource_size_in_pixels. This CL adds the missing field and updates the corresponding test. BUG=659601 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/3f6957ecf9d02fd3b022a9c3709e05bd51ceeeaf Cr-Commit-Position: refs/heads/master@{#435686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M cc/ipc/quads.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M cc/ipc/quads_struct_traits.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/ipc/quads_struct_traits.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
Fady Samuel
4 years ago (2016-12-01 16:22:47 UTC) #4
Fady Samuel
4 years ago (2016-12-01 16:22:48 UTC) #5
Tom Sepez
lgtm
4 years ago (2016-12-01 17:53:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541403002/1
4 years ago (2016-12-01 17:56:05 UTC) #11
Fady Samuel
+vmpstr@ for cc signoff.
4 years ago (2016-12-01 18:00:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/316506)
4 years ago (2016-12-01 18:03:41 UTC) #15
vmpstr
lgtm
4 years ago (2016-12-01 19:25:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541403002/1
4 years ago (2016-12-01 20:02:48 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:09:19 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-01 20:13:42 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f6957ecf9d02fd3b022a9c3709e05bd51ceeeaf
Cr-Commit-Position: refs/heads/master@{#435686}

Powered by Google App Engine
This is Rietveld 408576698