Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/sessions/session_service.cc

Issue 25414005: Clear session-only data when all browser windows are closed. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_service.cc
diff --git a/chrome/browser/sessions/session_service.cc b/chrome/browser/sessions/session_service.cc
index 8af213819455fd1c504812e703144914eaef1338..d7fdb81b54c54b62c6f035bd37d6328577a61f6d 100644
--- a/chrome/browser/sessions/session_service.cc
+++ b/chrome/browser/sessions/session_service.cc
@@ -16,12 +16,15 @@
#include "base/metrics/histogram.h"
#include "base/pickle.h"
#include "base/threading/thread.h"
+#include "chrome/browser/background/background_mode_manager.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sessions/session_backend.h"
#include "chrome/browser/sessions/session_command.h"
+#include "chrome/browser/sessions/session_data_deleter.h"
#include "chrome/browser/sessions/session_restore.h"
#include "chrome/browser/sessions/session_tab_helper.h"
#include "chrome/browser/sessions/session_types.h"
@@ -338,6 +341,12 @@ void SessionService::WindowClosed(const SessionID& window_id) {
else
ScheduleCommand(CreateWindowClosedCommand(window_id.id()));
}
+#if !defined(OS_MACOSX) && !defined(OS_CHROMEOS)
marja 2013/10/16 14:18:08 Why not for mac and chromeos? Because of some "how
Sam McNally 2013/10/16 23:30:59 Correct. Switched to kBrowserAliveWithNoWindows an
+ if (!has_open_trackable_browsers_ &&
+ !g_browser_process->background_mode_manager()->IsBackgroundModeActive()) {
+ DeleteSessionOnlyData(profile());
+ }
+#endif
}
void SessionService::SetWindowType(const SessionID& window_id,

Powered by Google App Engine
This is Rietveld 408576698