Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2541363002: Reload Reloaded: remove experimental flag that has been enabled by default (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, caseq+blink_chromium.org, creis+watch_chromium.org, pfeldman+blink_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), lushnikov+blink_chromium.org, blink-reviews-api_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, apavlov+blink_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org, mmenke, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reload Reloaded: remove experimental flag that has been enabled by default feastures::kNonValidatingReloadOnNormalReload has been enabled for all users from m54, and now it reached to Stable channel. Let's remove experimental flag so to make some cleanups. BUG=670232, 591245 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/980f117021a4247387809df1eb1ae27871284a2e Cr-Commit-Position: refs/heads/master@{#435881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -124 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M content/browser/loader/reload_cache_control_browsertest.cc View 5 chunks +2 lines, -49 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Takashi Toyoshima
creis: content tkent: Blink isherman: testing Can you take a look (if tests pass)?
4 years ago (2016-12-01 11:19:16 UTC) #9
tkent
On 2016/12/01 at 11:19:16, toyoshim wrote: > tkent: Blink lgtm
4 years ago (2016-12-01 23:23:39 UTC) #12
Charlie Reis
Thanks for the cleanup! content/ LGTM.
4 years ago (2016-12-01 23:36:37 UTC) #13
Ilya Sherman
testing/variations/fieldtrial_testing_config.json lgtm, thanks
4 years ago (2016-12-02 01:41:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541363002/1
4 years ago (2016-12-02 08:10:44 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 08:16:26 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-02 08:18:43 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/980f117021a4247387809df1eb1ae27871284a2e
Cr-Commit-Position: refs/heads/master@{#435881}

Powered by Google App Engine
This is Rietveld 408576698